chore: Add local changes from Windows copy #2
No reviewers
Labels
No labels
bug
documentation
duplicate
enhancement
good first issue
help wanted
invalid
question
v1.3.0
v1.4.0
wontfix
Compat/Breaking
Kind/Bug
Kind/Documentation
Kind/Enhancement
Kind/Feature
Kind/Security
Kind/Testing
Priority
Critical
Priority
High
Priority
Low
Priority
Medium
Reviewed
Confirmed
Reviewed
Duplicate
Reviewed
Invalid
Reviewed
Won't Fix
Status
Abandoned
Status
Blocked
Status
Need More Info
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
DSR-Labs/de.deinestrainreviews.autoDeleteUnconfirmedUsers!2
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "chore/add-local-files"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
This PR is being reviewed by Cursor Bugbot
Details
You are on the Bugbot Free tier. On this plan, Bugbot will review limited PRs each billing cycle.
To receive Bugbot reviews on all of your PRs, visit the Cursor dashboard to activate Pro and start your 14-day free trial.
@ -0,0 +4,4 @@<menuitem identifier="wcf.acp.menu.log.autoDelete" parent="wcf.acp.menu.log"><title language="de">Auto Delete Logs</title><title language="en">Auto Delete Logs</title><link>AutoDeleteLog{@$controller}</link>Bug: Invalid Variable Malforms Admin Menu Link
The menu link uses
AutoDeleteLog{@$controller}which includes a template variable{@$controller}that doesn't exist in the ACP menu context. This will result in a malformed or broken menu link. The link should be justAutoDeleteLogor follow WoltLab's proper controller naming convention without template variables.@ -54,0 +94,4 @@$user['email']]);}}Bug: SQL LIMIT: The Hidden Danger of PDO Binding
The SQL query uses a placeholder for
LIMIT ?and binds$limitas a parameter viaexecute(). In PDO, parameters are bound as strings by default, which can cause MySQL to treat the LIMIT value as a string rather than an integer. This may result in SQL errors or unexpected behavior depending on MySQL version and configuration. The old code usedprepare($sql, $limit)which handled this differently.@ -0,0 +27,4 @@<ul><li>{lang}wcf.user.userID{/lang}: {$log->userID}</li><li>{lang}wcf.user.username{/lang}: {$log->username|encodeJS}</li><li>{lang}wcf.user.email{/lang}: {$log->email|encodeJS}</li>Bug: Incorrect JavaScript Encoding Breaks HTML
The template uses
encodeJSmodifier for displayingusernameandemailin HTML context. TheencodeJSmodifier is for JavaScript string encoding, not HTML output. This causes usernames and emails to be displayed incorrectly (e.g., quotes become\"). For HTML output in templates, variables are auto-escaped by default or should use appropriate HTML encoding.Bug: Option Display Logic: Negation Inconsistency
The
enableoptionsattribute uses!autodelete_log_anonymousto conditionally show the retention period option when anonymous logging is disabled. However, the negation syntax with!appears inconsistent with how the main deletion option usesenableoptionswithout negation. This may not work as intended in WoltLab's option system, potentially causing the retention period field to display incorrectly or not at all.Pull request closed